[HLSL] Create HLSL legalization passes #123811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
commented
Jan 21, 2025
| @@ -61,7 +61,7 @@ unsigned RemoveDupes(unsigned Buf[MAX], unsigned size) { | |||
| } | |||
|
|
|||
|
|
|||
| RWBuffer<unsigned> Indices; | |||
| RWBuffer<unsigned> Indices : register(u0); | |||
There was a problem hiding this comment.
Resources without explicit register assignments are not supported yet. If we do not do this then we end up with a handle that is zero initialized, which causes problems.
You can test this locally with the following command:git-clang-format --diff 6518b121f037717fd211c36659f7b25266424719 834f6be33005c6fd289e776ad5dbeeebc5509695 --extensions cpp,h -- clang/lib/CodeGen/BackendUtil.cpp llvm/lib/Target/DirectX/DirectXTargetMachine.cpp llvm/include/llvm/Transforms/HLSL/HLSLFinalizeLinkage.h llvm/lib/Transforms/HLSL/HLSLFinalizeLinkage.cppView the diff from clang-format here.diff --git a/llvm/lib/Transforms/HLSL/HLSLFinalizeLinkage.cpp b/llvm/lib/Transforms/HLSL/HLSLFinalizeLinkage.cpp
index 8b0b6ea1c1..143349b6c5 100644
--- a/llvm/lib/Transforms/HLSL/HLSLFinalizeLinkage.cpp
+++ b/llvm/lib/Transforms/HLSL/HLSLFinalizeLinkage.cpp
@@ -18,7 +18,7 @@ using namespace llvm;
static bool finalizeLinkage(Module &M) {
SmallPtrSet<Function *, 8> Funcs;
- for(auto &Var : M.globals()) {
+ for (auto &Var : M.globals()) {
if (Var.getLinkage() == GlobalValue::ExternalLinkage) {
Var.setLinkage(GlobalValue::InternalLinkage);
}
|
The semantics of HLSL require passes some passes to be run that will modify the llvm-ir created by clang to match what is expected by the backend. In this PR, wewe move the DXILFinalizeLinkage to be run for all backend. The pass is also renamed to HLSLFinalizeLinkage. A pass of the global opt pass is run afterwards. Fixes llvm#122767.
s-perron
force-pushed
the
handle_wrapper
branch
from
2de3c0d to
4e62f38
Compare
|
@llvm-beanz Let me know if this is a reasonable direction to go. I'll have update a lot of tests, and I don't want to do that unless we believe this is what we would like to do. |
s-perron
force-pushed
the
handle_wrapper
branch
from
d3e20bc to
834f6be
Compare
|
Sharing the code here makes sense to me, however, this does make the pass run significantly earlier in the DXIL pipeline. That might be fine but we'll have to make sure we aren't creating dead functions in any of the other DXIL backend passes that might have been cleaned up by this so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of HLSL require passes some passes to be run that will
modify the llvm-ir created by clang to match what is expected by the
backend.
In this PR, wewe move the DXILFinalizeLinkage to be run for all backend.
The pass is also renamed to HLSLFinalizeLinkage. A pass of the global opt
pass is run afterwards.
Fixes #122767.